Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Support different plugins to have the same name #92

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

chhy2009
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #92 (00351fe) into main (a2acc4f) will decrease coverage by 0.09485%.
The diff coverage is 20.00000%.

❗ Current head 00351fe differs from pull request most recent head 359996f. Consider uploading reports for the commit 359996f to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main         #92         +/-   ##
===================================================
- Coverage   81.81334%   81.71849%   -0.09485%     
===================================================
  Files            855         855                 
  Lines          33805       33832         +27     
===================================================
- Hits           27657       27647         -10     
- Misses          6148        6185         +37     
Files Coverage Δ
trpc/client/client_context.h 74.63768% <100.00000%> (ø)
trpc/common/plugin.h 87.50000% <ø> (ø)
trpc/common/trpc_plugin.h 94.11765% <66.66667%> (+6.61764%) ⬆️
trpc/naming/selector_workflow.cc 72.81553% <0.00000%> (-0.71389%) ⬇️
trpc/common/trpc_plugin.cc 58.23293% <12.00000%> (-5.15993%) ⬇️

... and 7 files with indirect coverage changes

@chhy2009 chhy2009 force-pushed the dev branch 3 times, most recently from f41888b to 00351fe Compare December 15, 2023 09:55
@trpc-admin trpc-admin merged commit c95fdcb into trpc-group:main Dec 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants