Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{rpcz, config}: provide AND, OR, NOT logic operation in record when rule, and update README #21

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

liuzengh
Copy link
Contributor

No description provided.

@liuzengh
Copy link
Contributor Author

Synchronize MRs related to rpcz in the intranet to prepare for optimizing the documentation later.

Pull Request Check / go-apidiff (pull_request) failed is expected, please ignore the failed check:

Run joelanford/go-apidiff@main
Run if [[ "trpc-group/trpc-go" == "joelanford/go-apidiff" && "latest" == "latest" ]]; then
++ go env GOPATH
+ GOPATH=/home/ubuntu/go
+ set +e
++ /home/ubuntu/go/bin/go-apidiff 71941c0f7e32cec11d4[8](https://github.com/trpc-group/trpc-go/actions/runs/6037198633/job/16380995912?pr=21#step:4:9)c0d6b5c28122788f57e8 --compare-imports=false --print-compatible=true --repo-path=.
+ OUTPUT='
trpc.group/trpc-go/trpc-go
  Incompatible changes:
  - RecordWhenConfig.ErrorCodes: removed
  - RecordWhenConfig.MinDuration: removed
  - RecordWhenConfig.SamplingFraction: removed
  Compatible changes:
  - (*RecordWhenConfig).UnmarshalYAML: added
  - RecordWhenConfig.ShouldRecord: added'
+ GOAPIDIFF_RC=1
+ set -e
+ '[' 1 -eq 0 ']'
+ echo semver-type=major
+ exit 1
Error: Process completed with exit code 1.

@liuzengh
Copy link
Contributor Author

liuzengh commented Sep 1, 2023

After the failure of the “lint (pull_request)” check , I can't see which line of code specifically went wrong. @Leoyoungxh

@liuzengh
Copy link
Contributor Author

liuzengh commented Sep 1, 2023

I have located the specific line of code through the error message. "lint (pull_request)" check could be further optimized.

@liuzengh liuzengh changed the title {rpcz, config}: provide AND, OR, NOT logic operation in record when rule {rpcz, config}: provide AND, OR, NOT logic operation in record when rule, and update README Sep 11, 2023
@sandyskies sandyskies merged commit 8a243e8 into trpc-group:main Sep 15, 2023
4 of 5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants