Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: sync "Bug Fixes" of the intranet version #161

Merged
merged 26 commits into from
Jan 25, 2024

Conversation

liuzengh
Copy link
Contributor

  • v0.16.1
  • v0.16.0 but not include
    • stream: notify server when client context canceled
    • client: fix possible nil method timeout
    • {restful}: continue to handle even if transcodeRequest failed
  • v0.15.1 but not include
    • transport: ensure that the timeout for UDP dialing takes effect
  • v0.15.0

RELEASE NOTES: NONE

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (65a60b1) 85.52917% compared to head (9fd8bb2) 86.05746%.

Files Patch % Lines
config/trpc_config.go 87.86127% 16 Missing and 5 partials ⚠️
http/transport.go 87.50000% 4 Missing and 2 partials ⚠️
config.go 55.55556% 2 Missing and 2 partials ⚠️
client/stream.go 78.57143% 2 Missing and 1 partial ⚠️
stream/server.go 96.42857% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##                main        #161         +/-   ##
===================================================
+ Coverage   85.52917%   86.05746%   +0.52829%     
===================================================
  Files            189         190          +1     
  Lines          16129       16360        +231     
===================================================
+ Hits           13795       14079        +284     
+ Misses          1774        1720         -54     
- Partials         560         561          +1     
Flag Coverage Δ
unittests 86.05746% <92.44060%> (+0.52829%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liuzengh liuzengh added the type/bug Fixes a newly discovered bug label Jan 23, 2024
Copy link
Contributor

@WineChord WineChord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuzengh
Copy link
Contributor Author

Compatibility analysis

The following two incompatibility changes are acceptable and have been fully discussed in mr in the intranet version:

  • trpc.group/trpc-go/trpc-go/http
    Incompatible changes:
    • FormSerialization: old is comparable, new is not
image
  • trpc.group/trpc-go/trpc-go/transport
    Incompatible changes:
    • ListenFd.OriginalListenCloser: removed
image

@sandyskies sandyskies merged commit 52df823 into trpc-group:main Jan 25, 2024
5 of 6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/bug Fixes a newly discovered bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants