Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

feat: split up deserialization and start on support for SSE #67

Merged
merged 18 commits into from
Oct 13, 2023
Merged

Conversation

KATT
Copy link
Member

@KATT KATT commented Oct 13, 2023

  • split up deserialization so the "json stream" is it's own construct
  • under that, we have a deserializeAsync that takes a an iterator of a predefined type

background: will enable us to do both SSE and JSON streams

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #67 (ff7178f) into main (24108bc) will increase coverage by 0.09%.
Report is 2 commits behind head on main.
The diff coverage is 96.52%.

❗ Current head ff7178f differs from pull request most recent head 79b1676. Consider uploading reports for the commit 79b1676 to get more accurate results

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   97.95%   98.04%   +0.09%     
==========================================
  Files          30       30              
  Lines        1466     1487      +21     
  Branches      171      173       +2     
==========================================
+ Hits         1436     1458      +22     
  Misses         28       28              
+ Partials        2        1       -1     
Flag Coverage Δ
unit 98.04% <96.52%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/async/handlers/tsonAsyncIterable.ts 100.00% <100.00%> (ø)
src/async/deserializeAsync.ts 98.46% <96.36%> (+0.55%) ⬆️

@KATT KATT changed the title feat: split up deserialization feat: split up deserialization and add support for SSE Oct 13, 2023
@KATT KATT changed the title feat: split up deserialization and add support for SSE feat: split up deserialization and start on support for SSE Oct 13, 2023
@KATT KATT merged commit 3bd9782 into main Oct 13, 2023
12 checks passed
@KATT KATT deleted the deserialize branch October 13, 2023 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant