-
-
Notifications
You must be signed in to change notification settings - Fork 4
feat: split up deserialization and start on support for SSE #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
Codecov Report
@@ Coverage Diff @@
## main #67 +/- ##
==========================================
+ Coverage 97.95% 98.04% +0.09%
==========================================
Files 30 30
Lines 1466 1487 +21
Branches 171 173 +2
==========================================
+ Hits 1436 1458 +22
Misses 28 28
+ Partials 2 1 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
deserializeAsync
that takes a an iterator of a predefined typebackground: will enable us to do both SSE and JSON streams