Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Magento APIs into the sample app #7

Open
trunghvbk opened this issue Jun 25, 2023 · 1 comment
Open

Apply Magento APIs into the sample app #7

trunghvbk opened this issue Jun 25, 2023 · 1 comment
Assignees
Labels
development For Developing doing Doing issue overdue Overdue issue

Comments

@trunghvbk
Copy link
Owner

I'm thinking about applying some of Magento APIs to making a sample e-commerce app with a few screens (probably Home and Cart screens)

@trunghvbk
Copy link
Owner Author

trunghvbk commented Jul 2, 2023

I created PR #10 to apply this issue
In this PR, I added

  • Network package to reuse for current the project and future projects.
  • Implement Magento get product list API
    But for now, we have no working Magento site to test the implementation

TODOs:

  • Configure a working Magento site to test
  • Consider refactoring the Service layer, for example ProductService is inside the product feature, but MProductService is inside the common folder magento_apis. It seems not good at all.
  • Write unit tests for Network package and new controllers, services, models, ...

@trunghvbk trunghvbk added overdue Overdue issue doing Doing issue labels Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development For Developing doing Doing issue overdue Overdue issue
Projects
None yet
Development

No branches or pull requests

1 participant