Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Custom Response status code and headers on block action #86

Closed
aairey opened this issue Jan 7, 2022 · 6 comments
Closed

Support Custom Response status code and headers on block action #86

aairey opened this issue Jan 7, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@aairey
Copy link

aairey commented Jan 7, 2022

The terraform resource supports it already, please update the module to support it as well.

hashicorp/terraform-provider-aws#18754

@rpdelaney rpdelaney self-assigned this Oct 26, 2022
@rpdelaney
Copy link
Contributor

Hello @aairey ! Just to make sure we understand, you want an input variable that will pass-through to the custom_response_body block described here. Is that right?

@aairey
Copy link
Author

aairey commented Oct 26, 2022

Correct!

@rpdelaney
Copy link
Contributor

Ok, got it. That seems like something we'd like to support. I'll add it to our roadmap for engineers not on client projects to take on; in the mean time, I'd be happy to review a PR :)

@rpdelaney rpdelaney added the enhancement New feature or request label Oct 26, 2022
@rpdelaney rpdelaney removed their assignment Oct 27, 2022
@rpdelaney
Copy link
Contributor

I'm not seeing support in this module for a custom_response field. I think that may have to be added as well.

@rpdelaney
Copy link
Contributor

@aairey We recognize the value of this, but it's not something we need at the moment. If you can send us a PR we'll be happy to take a look :)

@xgt001
Copy link

xgt001 commented Jul 5, 2023

hi @rpdelaney , would you be interested in accepting my PR. If this is something you can see being accepted, I am happy to refine it and complete this piece by adding support to JSON and HTTP response bodies , as well as adding support for multiple response bodies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants