Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process flow diagram #53

Open
allant0 opened this issue Oct 31, 2022 · 10 comments · May be fixed by #75
Open

Process flow diagram #53

allant0 opened this issue Oct 31, 2022 · 10 comments · May be fixed by #75
Assignees
Labels
priority: low This issue is "nice to have" for the next release, but could be deferred if time runs out. status: needs-review status: pr-completed The issue is linked to a PR that is complete and waiting for review. type: admin This issue requires an action by an admin.

Comments

@allant0
Copy link

allant0 commented Oct 31, 2022

The team introduced a process flow that included a slide that showed how submissions would be reviewed by editors. During a call we discussed that this item was actually the editors would review with the working group in an iterative manner to ensure the approved submission reflected the groups input not just the submitters input. The team agreed to update the diagram to show this aspect of the review cycle including group review and iteration on the submission.

Posting this submission for Andor as a reminder based on his request.

@allant0 allant0 added the priority: low This issue is "nice to have" for the next release, but could be deferred if time runs out. label Oct 31, 2022
@andorsk andorsk added the type: admin This issue requires an action by an admin. label Nov 1, 2022
@andorsk
Copy link
Contributor

andorsk commented Nov 1, 2022

Thanks @allant0!

I'm not sure what diagram you are referring to but maybe someone can help pin point it. @a-fox you mentioned you knew which one it was? Can someone point this issue to the direction of the existing diagram?

We can of course, always make a new visual diagram but I think to @allant0's point, this is something specifically mentioned over an older ToIP call. I can take this, but @a-fox, you said you wanted to take this. I'm happy to assign to you?

@allant0
Copy link
Author

allant0 commented Nov 1, 2022

There was a slide deck where the folks introduced the new process. There was one slide that had a good diagram on the process for PR submission, editor review and merge...etc. We agreed that the diagram didn't show the part where the group would review and come to agreement. The diagram implied that editors made all the decisions which everyone agreed was not the case. This diagram was considered good to include in the explanation of the process.

@andorsk
Copy link
Contributor

andorsk commented Nov 1, 2022

@allant0 understood that there was a slide as some point in the past shown that represents the flow, that currently doesn't exist in the documentation, but would be helpful to add in. That makes sense. The problem is that I have no idea where that slide is or what that slide looks like. I'll be happy to review it and add it in if someone can point me to it.

I'll need someone ( if not you then someone else ), to provide one of the following:

  • If you know the relative date, we can pin it probably through the TAFT meeting notes.
  • If you know who presented it, we can tag them here and hope they can share the link.
  • If you have the slides link, even better.
  • If you have the actual image, obviously that would work.

@a-fox you seemed to suggest you know where the slide is. Could you point us to the slides?

@a-fox
Copy link
Contributor

a-fox commented Nov 9, 2022

Ah, absolutely! The process in question is in this slidedeck (located in the ToIP shared GDrive): https://docs.google.com/presentation/d/1IysE0KvrRlD8pPE2qtB-huuQcyQAVQ2hLz4bCgH_UFg/edit#slide=id.p
You need to be a ToIP member with registered email address to gain access to it.

The image in question is this one:
image

IIRC the discussion was to add the 'editor subgroup' if further discussion was needed.
How the process look at this point? Should it still be amended?

@allant0
Copy link
Author

allant0 commented Nov 10, 2022

I posted a comment directly in the google doc. I believe this diagram does not reflect the agreement that was discussed on the call.

i.e. the iterative process of a submission by editor review must include broader group review also especially on technical matters that require consensus. That was what sounded like we all agreed to on the call but this diagram above suggests that only editors will iterate on a submission. This implies editors could end up changes the submission substantially without group consensus. None of us want that.

@andorsk
Copy link
Contributor

andorsk commented Nov 11, 2022

fair. Thanks for the links. I'll see if I can make some updates here and get a PR in with the adjustments, for review of everyone else. I don't think this is high priority, so not going to put the gas on this unless someone feels otherwise?

@talltree
Copy link
Collaborator

From the discussion in the Google Slides file containing the diagram, it looks like the fix is done. If so, can we close this issue?

@a-fox a-fox added status: pr-in-progress The issue has been assigned and work is in progress. and removed status: needs-review labels Nov 14, 2022
@a-fox a-fox self-assigned this Nov 14, 2022
@a-fox
Copy link
Contributor

a-fox commented Nov 14, 2022

@talltree, I still need to update the GOVERNANCE -document with the process image. I will do a PR today.

@talltree
Copy link
Collaborator

@a-fox Very good, once you do that, you can close this issue, thanks.

@a-fox a-fox linked a pull request Nov 14, 2022 that will close this issue
@a-fox
Copy link
Contributor

a-fox commented Nov 14, 2022

I added a PR to add the process image & description: #75

@a-fox a-fox added status: pr-completed The issue is linked to a PR that is complete and waiting for review. status: needs-review and removed status: pr-in-progress The issue has been assigned and work is in progress. labels Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low This issue is "nice to have" for the next release, but could be deferred if time runs out. status: needs-review status: pr-completed The issue is linked to a PR that is complete and waiting for review. type: admin This issue requires an action by an admin.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants