Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

**Is your feature request related to a problem? Please describe.** #28932

Closed
Jackywu001 opened this issue Aug 13, 2024 · 0 comments
Closed

**Is your feature request related to a problem? Please describe.** #28932

Jackywu001 opened this issue Aug 13, 2024 · 0 comments

Comments

@Jackywu001
Copy link

Is your feature request related to a problem? Please describe.
I didn't want to rely on starscream for my app, but ran into issues integrating my own socket, so I gave in and updated my app to use the same setup as your example app. Now i'm getting crash reports from the starscream version used in the example project, when it tries to set http headers. I looked into it and noticed your example app is using a fairly old version of starscream and the supplied protocol WebSocketConnecting doesn't match the latest interface.

Describe the solution you'd like
Can you either update WebSocketConnecting so that the latest starscream can be plugged in more easily, or can you provide docs/sample for using the latest. E.g. updating the example to starscream v4+

Describe alternatives you've considered
I tired building my own websocket, but i'm having a lot of issues keeping the connection open. By default the inbuilt iOS sockets close after 5 minutes of no messages. I'm having a lot of issues trying to balance the reconnections with users trying to make use of it. The ideal solution here is for WC2 to implement a custom hidden keepalive message, thats sent on a regular basis to keep the socket open, rather than relying on reconnection. Websocket implementations vary wildly across platforms, custom keepalives has been the only reliable means of keeping connections open in various past projects/companies

Originally posted by @simonmcl in WalletConnect/WalletConnectSwiftV2#1205

@curiouschonk curiouschonk closed this as not planned Won't fix, can't repro, duplicate, stale Aug 14, 2024
@trustwallet trustwallet locked as spam and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants