Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate aeternity blockchain #260

Closed
15 tasks
vikmeup opened this issue Apr 3, 2019 · 39 comments
Closed
15 tasks

Integrate aeternity blockchain #260

vikmeup opened this issue Apr 3, 2019 · 39 comments

Comments

@vikmeup
Copy link
Contributor

vikmeup commented Apr 3, 2019

Name: aeternity

HD Derivation Scheme: 457

Symbol: AE

Documentation:
https://aeternity.com/
https://github.com/aeternity

Reason:

Checklist

  • Implement functionality in C++. Put it in a subfolder of src/.
    • Address (if necessary)
    • Transaction (if necessary)
    • Signer
  • Write unit tests. Put them in a subfolder of tests/.
    [ ] Mnemonic phrase - > Address derivation test. Put this test in the CoinTests.cpp file
  • Add relevant constants in TWCoinType, TWP2SHPrefix, TWEthereymChainID, TWHRP, etc., as necessary.
  • Return correct curve and purpose in src/Coin.cpp.
  • Implement address validation and derivation in src/Coin.cpp.
  • Implement coin configuration src/include/TWCoinTypeConfiguration.cpp.
  • Write interface header in include/TrustWalletCore and implement the interface in src/interface.
    • Address interface (if necessary).
    • Signing interface.
  • Validate generated code in Android an iOS projects. Write integration tests for each.
  • Add a coin icon to "Supported Blockchains" section in README.md
@eminogrande
Copy link

eminogrande commented Apr 10, 2019

Thank you @vikmeup we're spreading this in our community and we already have candidates which would like to tackle this tasks. They will followup here soon.

Edit: btw. its aeternity not Aethernity :)

@vikmeup vikmeup changed the title Integrate Aethernity blockchain Integrate aeternity blockchain Apr 10, 2019
@johnnynanjiang
Copy link
Contributor

Thank you @vikmeup we're spreading this in our community and we already have candidates which would like to tackle this tasks. They will followup here soon.

Edit: btw. its aeternity not Aethernity :)

Hi @eminogrande, any update on this? Is there anyone going to work on it from your community?

@Defuera
Copy link
Contributor

Defuera commented May 1, 2019

I'm on it

@johnnynanjiang
Copy link
Contributor

Hi @Defuera, please check with the owner of this issue before you start.

@Defuera
Copy link
Contributor

Defuera commented May 5, 2019

@johnnynanjiang hi, it's been discussed with Viktor before.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 8.0 ETH (1342.92 USD @ $167.87/ETH) attached to it as part of the aeternity fund.

@gitcoinbot
Copy link

gitcoinbot commented May 6, 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Workers have applied to start work.

These users each claimed they can complete the work by 12 months from now.
Please review their action plans below:

1) touhonoob has applied to start work (Funders only: approve worker | reject worker).

Learn more on the Gitcoin Issue Details page.

GitHub
Cross-platform, cross-blockchain wallet library. Contribute to TrustWallet/wallet-core development by creating an account on GitHub.

@gitcoinbot
Copy link

gitcoinbot commented May 6, 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 10 months, 2 weeks from now.
Please review their action plans below:

1) defuera has been approved to start work.

I'm going to follow the Checklist
2) defuera has been approved to start work.

I'm going to follow the Checklist

Learn more on the Gitcoin Issue Details page.

@zyfrank
Copy link

zyfrank commented May 7, 2019

@Defuera @johnnynanjiang @eminogrande
Just notice @Defuera's comments, are you working on this issue now?

@Defuera
Copy link
Contributor

Defuera commented May 7, 2019

@zyfrank yeap

@zyfrank
Copy link

zyfrank commented May 8, 2019

@eminogrande seems the right person for this task is @Defuera ,considering he has spent some time on it?

@eminogrande
Copy link

@zyfrank and @Defuera you can also work together, i'm happy to increase the bounty. Two pairs of eyes are always good. I'd like @vikmeup to confirm the final code before the bounty gets paid. Thanks for your efforts!

@vikmeup
Copy link
Contributor Author

vikmeup commented May 9, 2019

@zyfrank can you connect to me on telegram @vikmeup? I will connect you together

@gitcoinbot
Copy link

@Defuera Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@Defuera Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Defuera added a commit to Defuera/wallet-core that referenced this issue May 11, 2019
@gitcoinbot
Copy link

@Defuera Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@Defuera Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Defuera added a commit to Defuera/wallet-core that referenced this issue May 11, 2019
Defuera added a commit to Defuera/wallet-core that referenced this issue May 11, 2019
Defuera added a commit to Defuera/wallet-core that referenced this issue May 11, 2019
@gitcoinbot
Copy link

@Defuera Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@Defuera Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Defuera added a commit to Defuera/wallet-core that referenced this issue May 13, 2019
Defuera added a commit to Defuera/wallet-core that referenced this issue May 13, 2019
@Defuera
Copy link
Contributor

Defuera commented May 14, 2019

@Defuera Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Why is this keep showing up? PR is already in progress 🤔

@gitcoinbot
Copy link

@Defuera Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@Defuera Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Defuera added a commit to Defuera/wallet-core that referenced this issue May 30, 2019
Defuera added a commit to Defuera/wallet-core that referenced this issue May 30, 2019
Defuera added a commit to Defuera/wallet-core that referenced this issue May 30, 2019
Defuera added a commit to Defuera/wallet-core that referenced this issue May 30, 2019
Defuera added a commit to Defuera/wallet-core that referenced this issue May 30, 2019
Defuera added a commit to Defuera/wallet-core that referenced this issue May 31, 2019
Defuera added a commit to Defuera/wallet-core that referenced this issue May 31, 2019
Defuera added a commit to Defuera/wallet-core that referenced this issue May 31, 2019
Defuera added a commit to Defuera/wallet-core that referenced this issue May 31, 2019
Defuera added a commit to Defuera/wallet-core that referenced this issue May 31, 2019
Defuera added a commit to Defuera/wallet-core that referenced this issue May 31, 2019
Defuera added a commit to Defuera/wallet-core that referenced this issue May 31, 2019
Defuera added a commit to Defuera/wallet-core that referenced this issue May 31, 2019
Defuera added a commit to Defuera/wallet-core that referenced this issue May 31, 2019
Defuera added a commit to Defuera/wallet-core that referenced this issue May 31, 2019
Defuera added a commit to Defuera/wallet-core that referenced this issue May 31, 2019
Defuera added a commit to Defuera/wallet-core that referenced this issue May 31, 2019
Defuera added a commit to Defuera/wallet-core that referenced this issue May 31, 2019
Defuera added a commit to Defuera/wallet-core that referenced this issue May 31, 2019
Defuera added a commit to Defuera/wallet-core that referenced this issue May 31, 2019
Defuera added a commit to Defuera/wallet-core that referenced this issue May 31, 2019
Defuera added a commit to Defuera/wallet-core that referenced this issue May 31, 2019
Defuera added a commit to Defuera/wallet-core that referenced this issue May 31, 2019
Defuera added a commit to Defuera/wallet-core that referenced this issue May 31, 2019
Defuera added a commit to Defuera/wallet-core that referenced this issue May 31, 2019
Defuera added a commit to Defuera/wallet-core that referenced this issue May 31, 2019
Defuera added a commit to Defuera/wallet-core that referenced this issue May 31, 2019
Defuera added a commit to Defuera/wallet-core that referenced this issue May 31, 2019
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 8.0 ETH (1968.7 USD @ $246.09/ETH) has been submitted by:

  1. @defuera

@eminogrande please take a look at the submitted work:


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants