Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample app: subscriptions over configuration change #4

Open
tomhermann opened this issue Dec 30, 2017 · 0 comments
Open

Sample app: subscriptions over configuration change #4

tomhermann opened this issue Dec 30, 2017 · 0 comments

Comments

@tomhermann
Copy link
Member

Currently when a view is paused, takeView() is invoked, which disposes the subscription. It would be better if the progress continued.

Perhaps instead of long lived presenters or singleton models, consider something better.

It should:

  • Generally: Continue running on configuration change, stop running when destroyed.
  • Bonus pts: Configure when the subscription should be disposed: if it is a destructive server operation, keep on going. If it is just a view subscription, kill it when you feel like it.
  • Bonus pts: Consider using a Lifecycle observer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant