Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making SmallInteger a wrapper over SmallBigInt, not vice versa #288

Open
andreubotella opened this issue Jul 7, 2024 · 0 comments

Comments

@andreubotella
Copy link
Collaborator

Currently it is possible to do something like Value::Integer(SmallInteger::try_from(SmallInteger::MAX_BIGINT).unwrap()), which does not panic and would result in an invalid value (because SmallInteger::MAX_BIGINT is outside the range of a safe integer).

To avoid this, we should probably make the base type SmallBigInt, since its valid range is larger, and make SmallInteger a wrapper over it that checks the range at construction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant