Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom resource size for different deployment #74

Open
ghiyastfarisi opened this issue Nov 2, 2022 · 3 comments
Open

Add custom resource size for different deployment #74

ghiyastfarisi opened this issue Nov 2, 2022 · 3 comments

Comments

@ghiyastfarisi
Copy link

Current values.yaml only handle single resources value to update both the resource size for deployment_backend and deployment_jobs

image

but since the deployment job is rarely being used in some of our usages it is wise to have multiple input value for resources configuration inside values.yaml

example
in values.yaml accept resourceJobs

resources: {}
resourcesJobs: {}

in templates/deployment_jobs.yaml

{{ toYaml .Values.resourcesJobs | indent 10 }}
@lado936
Copy link

lado936 commented Jul 26, 2024

@avimoondra Hello, we have this specific requirement for our deployment also, got pr ready also with the ability to set optional resources for jobs runner, is there any way i can contribute or you can add this possibility?

@samsternatretool
Copy link

@lado936 contributions welcome. Feel free to send a PR. And if you already did, can you link it here?

@lado936
Copy link

lado936 commented Jul 29, 2024

Sorry for late answer, @samsternatretool i cant push my changes to any branch, got permission denied, is there anything i should do first before pushing changes in your repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants