Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointbuy Calculator text cut off on horizontal small screens #37

Open
samcorcoran opened this issue Aug 31, 2014 · 1 comment
Open

Pointbuy Calculator text cut off on horizontal small screens #37

samcorcoran opened this issue Aug 31, 2014 · 1 comment
Labels
Milestone

Comments

@samcorcoran
Copy link
Contributor

The + and - buttons, and the "Points: #" are affected.

Because the calculator attempts to fit everything vertically onto the screen (i.e. squashes things smaller rather than offering a scroll bar) mobile devices (I saw this on a Samsung Galaxy S3) when turned horizontally can offer too little height for some of the components.

The + and - buttons failed to centre their symbols on the (rather thin, in terms of height) button. This is possibly due to a minimum fixed padding above these symbols? This lack of vertical centring is not good, but the plus symbol is partially cut off which is worse.

The "Points: #" row is similarly cut off, with the bottom of the text being clipped off.

For some minimum-height screens, perhaps this view should become scrollable.

@tsiemens tsiemens added the bug label Aug 31, 2014
@tsiemens tsiemens added this to the 2.2 milestone Aug 31, 2014
@tsiemens
Copy link
Owner

tsiemens commented Sep 2, 2014

Apparently easier said than done. Android does not appear to have a good mechanism to create a table with scrollable columns, with a fixed header, which aligns perfectly with the columns, at least not with a table view.

I'd say this might just be easier to do as we do our inventory and spell lists, with linear layouts and weighting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants