Fix bug where parse_time was parsing CLI flags on F5
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paoloose
force-pushed
the
master
branch
2 times, most recently
from
f570495 to
1ec5afe
Compare
|
That "force-pushed" is because I had to revert some commits I made that were not related to this pr |
paoloose
commented
Feb 18, 2023
main.c
Outdated
| @@ -237,20 +239,10 @@ int main(int argc, char **argv) | |||
| } break; | |||
|
|
|||
| case SDLK_F5: { | |||
| displayed_time = 0.0f; | |||
| paused = false; | |||
There was a problem hiding this comment.
I removed this paused = false which was causing the paused state not to be maintained on F5. (Timers should automatically pause when they are restarted, this did the opposite)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!!! I added a variable
float start_timeinmain()to save the initial timer time, so there is no need to parse it again on F5.Also restarting with F5 now has no effect on clock mode.
I couldn't resist changing the boolean integers as boolean types, sorry about that
fixes #29