Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Install IRO:// uri is not registered and .iro extensions not registered to 7th Heaven #212

Open
barkermn01 opened this issue Aug 9, 2024 · 5 comments
Labels
bug Something isn't working help wanted Extra attention is needed priority/P1 likely to affect end users

Comments

@barkermn01
Copy link
Member

barkermn01 commented Aug 9, 2024

Describe the bug
I have clean installed 7th heaven, then tried both canary build and stable build the General Settings shows i have "Open iros:// links with 7th Heaven" & "Open Mod Files with 7th Heaven", and neither are working,

** Versions **
[x] Tested on latest stable version
[ ] Pre-release only bug

To Reproduce
Clean windows install 7th heaven using installer on Tsunamods / 7thheaven.rocks website let it complete, make sure the Shell integrations are enabled
try visiting a iros:// uri and it wont work it will just google the URI, download a mod .iro file file does not have icon in windows and opening it asks user to select application to open it

Expected behavior
The Shell registations work so the URI's and .Iro files correctly open 7th heaven

Screenshots
7th heaven settings window
Windows Shell not pressent

Desktop (please complete the following information):

  • OS: Windows
  • Version: 11
  • Build: 22631.3958

Additional context
Tsuna and MikeDoesAudio were on call and witnessed it

@julianxhokaxhiu julianxhokaxhiu added bug Something isn't working help wanted Extra attention is needed labels Aug 9, 2024
@julianxhokaxhiu
Copy link
Member

Thanks for the report. Out of curiosity, were you prompted to run the command line once you clicked save? That should have generated a bat file in the 7thWorkshop/temp folder. Care to share what you got so I can check if the registry paths were created for you?

@julianxhokaxhiu julianxhokaxhiu added the priority/P1 likely to affect end users label Aug 17, 2024
@barkermn01
Copy link
Member Author

There is nothing inside the directory now, does it auto delete it when it starts up again, i will try to create it and capture it now.

@barkermn01
Copy link
Member Author

So Turning them off.

@echo off
@reg.exe delete "HKCR\iros" /f /reg:64
@reg.exe delete "HKCR\7thHeaven\shell\Unpack IRO\command" /f /reg:64
@reg.exe delete "HKCR\7thHeaven\DefaultIcon" /f /reg:64
@reg.exe delete "HKCR\.iro" /f /reg:64
@reg.exe delete "HKCR\.irop" /f /reg:64
@reg.exe delete "HKCR\Directory\shell\Pack into IRO" /f /reg:64
@reg.exe delete "HKCR\7thHeaven\shell\Unpack IRO" /f /reg:64

adding them:

@echo off
@reg.exe add "HKEY_CLASSES_ROOT\iros" /f /ve /d "7H Catalog Subscription" /t REG_SZ /reg:64
@reg.exe add "HKEY_CLASSES_ROOT\7thHeaven\DefaultIcon" /f /ve /d """C:\Users\Martin\AppData\Local\Programs\7th Heaven\7th Heaven.exe""" /t REG_SZ /reg:64
@reg.exe add "HKEY_CLASSES_ROOT\.iro" /f /ve /d "7thHeaven Mod" /t REG_SZ /reg:64
@reg.exe add "HKEY_CLASSES_ROOT\.irop" /f /ve /d "7th Heaven Mod Patch" /t REG_SZ /reg:64
@reg.exe add "HKEY_CLASSES_ROOT\.irop\DefaultIcon" /f /ve /d """C:\Users\Martin\AppData\Local\Programs\7th Heaven\7th Heaven.exe""" /t REG_SZ /reg:64
@reg.exe add "HKEY_CLASSES_ROOT\.irop\shell\open\command" /f /ve /d """C:\Users\Martin\AppData\Local\Programs\7th Heaven\7th Heaven.exe"" /OPENIROP:""%%1""" /t REG_SZ /reg:64
@reg.exe delete "HKCR\Directory\shell\Pack into IRO" /f /reg:64
@reg.exe delete "HKCR\7thHeaven\shell\Unpack IRO" /f /reg:64

That ran, and yet still IRO file on my system

image

And if i try using an IRO:// schema URI i get
image

@wturner859
Copy link

wturner859 commented Feb 4, 2025

There are a couple things I want to add to this issue.

  1. in order for any context menu options to work correctly, I had to manually associate iro files with 7th heaven. I also had generic icons for .iro files until I "Open with..", selected 7th Heaven and "Always with". Then .iro files had the appropriate icon and context menu options worked correctly including "pack iro", "unpack iro" and double clicking an iro. 7th Heaven did not do this for me automatically even with "open mod files with 7h" ticked which may have also been the same problem Martin was experiencing.

  2. External downloads is a different story. First off, clicking an iros:// link will do nothing if 7h is open. It must be closed first. Second, I'm not sure what's wrong with Martin's link that sends him to google, but the links from 7thheaven.rocks do seem to be "opened" by 7h.. I put "open" in quotation marks because the mod is not actually downloaded. 7h attempts to import it as a catalog instead... If you go to iros://Url/http$qhimm.7thheaven.rocks/Catalog%204.0/Media/DrLilo%20-%20Chibi%20FMV%20Replacement.iro for example (while 7h is closed), the data of the mod is seemingly downloaded (or at least read? based on the time it takes depending on the size of the mod and the speed given in MB/s) once as resolving the "catalog"

Image

and then again as checking the "catalog"

Image

You're then given a bad xml error (because of course it's a bad xml. it's not an xml at all.) and the mod is not added to your library. You will have a new catalog entry, though

Image

this could also probably be considered a separate issue.

@julianxhokaxhiu
Copy link
Member

julianxhokaxhiu commented Feb 4, 2025

Thanks Bonez for the feedback.

Let me unpack separately:

  1. Did you try this on top of the latest canary? I installed my Win11 from scratch recently, I installed 7th and I enabled the flag in the General Settings, hit Save and I have icons, context menu associations and much more done well. I wonder if you're having old registry entries done wrong which now create confusion on Explorer. I'd suggest running a registry cleaner like Glary Utilities and see if you can repro this again by simply uninstalling and reinstalling the app. The correct testing pathway would be:

    • Uninstall 7th
    • Run Glary Utilities registry cleaner
    • Reboot
    • Install 7th
    • Enable the flag in General Settings, hit Save and see how it goes
  2. It is known, in order to install a mod you need to use the iros://mod/ path instead of only iros:// which is meant for catalogs. Howerver I am not sure what else expects after that path so feel free to do some tests and report back how it goes. But I agree, this is a separate discussion and we continue talking about it on Discord.

Hope this helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed priority/P1 likely to affect end users
Projects
None yet
Development

No branches or pull requests

3 participants