Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing error due to a bug #35

Open
jvictorchen opened this issue Sep 15, 2016 · 0 comments
Open

Parsing error due to a bug #35

jvictorchen opened this issue Sep 15, 2016 · 0 comments

Comments

@jvictorchen
Copy link
Contributor

The national number of phone number +33 07856952 should be 07856952. But the code is returning 78569522 as the result. This is caused by a bug in line

potentialNationalNumber := builder.NewBuilder(normalizedNationalNumber.Byte())

The problem is that we are creating potentialNationalNumber from normalizedNationalNumber.Byte(), which is a pointer. So any change in potentialNationalNumber will also change the value of normalizedNationalNumber.

I will submit a PR to address this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant