Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to update the rules to match isoCountry and number type #47

Open
fabriziomoscon opened this issue Feb 8, 2017 · 3 comments
Open

Comments

@fabriziomoscon
Copy link
Contributor

Hi @ttacon,
I have been using the library for few months and it works great, but sometimes the country and number type are not guessed correctly.
For example there are few exceptions I noticed for UK and Greece.
In UK some numbers country must belong to the Channel Islands so for example

countryTypeException{
			pattern:        "^\\+447781.*",
			isoCountryCode: "GU",
			numType:        "mobile",
			description:    "Sure mobile phones and pagers",
		}

And I found a special case for old greek pager that at the moment returns MOBILE.

It would be great to understand what is the process to update these rules and also import new updates from the original library you ported

Thanks much appreciated

@nicpottier
Copy link

nicpottier commented May 9, 2017

Just a heads up that we've started more active development on a fork of this library here: https://github.com/nyaruka/phonenumbers

Since ttacon seemed a bit busy. We've built a tool to update the metadata so curious if you see the same issues with our fork as it is using the current Google definitions.

@spacetourist
Copy link

well that's a bustling community.. sticking with @ttacon 👍

@ttacon
Copy link
Owner

ttacon commented Sep 1, 2017

@fabriziomoscon sorry for the very late reply! I'll add some unit tests later to allow me to dig into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants