Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistake in the implementation of current velocity array in the FillBatch method of the DataHandler class #5

Open
PFery4 opened this issue Sep 20, 2022 · 2 comments

Comments

@PFery4
Copy link
Contributor

PFery4 commented Sep 20, 2022

current_vel = np.array([trajectory.vel_vec[start_idx + tbp_step, 0], trajectory.vel_vec[

The definition of the current velocity array is incorrect. We can compare it with the way the current_pos array is implemented (which is the correct way), right above it

for prev_step in range(self.prev_horizon,-1,-1):
				current_pos = np.array([trajectory.pose_vec[start_idx + tbp_step - prev_step, 0], trajectory.pose_vec[
					                        start_idx + tbp_step - prev_step, 1]])
				current_vel = np.array([trajectory.vel_vec[start_idx + tbp_step, 0], trajectory.vel_vec[
					                        start_idx + tbp_step - prev_step - prev_step, 1]])

current_vel should be instead:


				current_vel = np.array([trajectory.vel_vec[start_idx + tbp_step - prev_step, 0], trajectory.vel_vec[
					                        start_idx + tbp_step - prev_step, 1]])
@bbrito
Copy link
Member

bbrito commented Sep 20, 2022

@PFery4 thanks for finding it! I guess we did this mistake when we were cleaning up the code for release. Can you please make a pull request with the fix? I do not have edit privileges anymore so someone else has to merge it.

@PFery4
Copy link
Contributor Author

PFery4 commented Sep 21, 2022

I'm not super familiar with how pull requests work exactly, will give it a try in a few hours if I have the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants