Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow control of vehicles other than the 'active one' #3

Open
tckarenchiang opened this issue May 28, 2021 · 4 comments · Fixed by #44
Open

Allow control of vehicles other than the 'active one' #3

tckarenchiang opened this issue May 28, 2021 · 4 comments · Fixed by #44
Labels
enhancement New feature or request help wanted lua Issues requiring changes/fixes to the Lua code

Comments

@tckarenchiang
Copy link
Contributor

Currently, only the vehicle in which the player 'sits' can be controlled.
We should allow all vehicles in the game to be controlled.
It should probably work like how AI vehicles are controlled by .lua scripts right now.

@tckarenchiang tckarenchiang changed the title Allow control of vehicles other than the 'active one' Allow control of vehicles other than the active one May 28, 2021
@tckarenchiang tckarenchiang changed the title Allow control of vehicles other than the active one Allow control of vehicles other than the 'active one' May 28, 2021
@gavanderhoorn gavanderhoorn added enhancement New feature or request help wanted lua Issues requiring changes/fixes to the Lua code labels May 31, 2021
@gavanderhoorn
Copy link
Member

@tckarenchiang: did you mean to close this issue?

I don't believe #44 implemented this, does it?

@tckarenchiang
Copy link
Contributor Author

@tckarenchiang: did you mean to close this issue?

I don't believe #44 implemented this, does it?

I thought commit e82eae8 did it?

@gavanderhoorn
Copy link
Member

Can users now control multiple vehicles other than the one the player is in by publishing Twist messages to specific topics?

How would they address specific vehicles?

IIUC, e82eae8 applies the same Twist to all vehicles. That would be something else.

@gavanderhoorn gavanderhoorn reopened this Sep 10, 2021
@tckarenchiang
Copy link
Contributor Author

Can users now control multiple vehicles other than the one the player is in by publishing Twist messages to specific topics?

How would they address specific vehicles?

IIUC, e82eae8 applies the same Twist to all vehicles. That would be something else.

Not yet in the previous PR, yes, you are right. I got confused.

This will be fixed in the later PR.

Thanks for reopening the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted lua Issues requiring changes/fixes to the Lua code
Development

Successfully merging a pull request may close this issue.

2 participants