Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close pipe file on unload of map? #4

Open
tckarenchiang opened this issue May 28, 2021 · 0 comments
Open

Close pipe file on unload of map? #4

tckarenchiang opened this issue May 28, 2021 · 0 comments
Labels
enhancement New feature or request lua Issues requiring changes/fixes to the Lua code

Comments

@tckarenchiang
Copy link
Contributor

In the spirit of properly managing resources, it might be nice to use that function to make sure the pipe file is properly closed. We cannot assume the user has called the necessary console commands to do that for us.

A check should of course be included to see whether the file is still open, and only attempt to close it if necessary.

It might be also good to think about other cleanup operations which could be performed by deleteMap(..)
Relevant thread: https://forum.giants-software.com/viewtopic.php?t=102709

@gavanderhoorn gavanderhoorn added enhancement New feature or request lua Issues requiring changes/fixes to the Lua code labels Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lua Issues requiring changes/fixes to the Lua code
Development

No branches or pull requests

2 participants