Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[networking] add prompt for continuing after updating ssh key #136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[networking] add prompt for continuing after updating ssh key #136

wants to merge 1 commit into from

Conversation

MatthijsBurgh
Copy link
Member

@MatthijsBurgh MatthijsBurgh commented Mar 9, 2020 •
edited
Loading

This probably prevents a lot of irritation.

@MatthijsBurgh MatthijsBurgh requested a review from ar13pit March 9, 2020 09:50
ar13pit
ar13pit requested changes Mar 10, 2020
View reviewed changes
networking/install.bash Show resolved Hide resolved
@ar13pit
Copy link
Contributor

ar13pit commented Mar 10, 2020

@MatthijsBurgh have a look

ar13pit
ar13pit previously approved these changes Mar 10, 2020
View reviewed changes
@MatthijsBurgh MatthijsBurgh force-pushed the fix/networking branch 2 times, most recently from 7319ff2 to 7a5714a Compare October 28, 2020 13:14
@MatthijsBurgh MatthijsBurgh requested a review from ar13pit October 11, 2021 11:28
@MatthijsBurgh
Copy link
Member Author

@ar13pit I still think that this is an improvement over the current situation. As people are not alerted that their ssh key changed. The networking target is completely ignored in CI, so no problems there.

@MatthijsBurgh
Copy link
Member Author

Ping @ar13pit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ar13pit ar13pit Awaiting requested review from ar13pit

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatthijsBurgh @ar13pit