Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracker] Feature Roadmap #11

Open
17 of 19 tasks
zenlex opened this issue Mar 10, 2024 · 4 comments
Open
17 of 19 tasks

[Tracker] Feature Roadmap #11

zenlex opened this issue Mar 10, 2024 · 4 comments

Comments

@zenlex
Copy link
Contributor

zenlex commented Mar 10, 2024

Routes:

  • Proposals
  • Drafts
  • Votes

Services:

  • Proposals
  • Drafts
  • Votes

Database:

  • Proposals
  • Drafts
  • Votes

Tests:

  • Proposals
  • Drafts
  • Votes

Validators:

  • Proposals
  • Drafts
  • Votes

General:

  • Containerization
  • Deployment CI
  • Documentation
  • Connect/Test with UI
@zenlex zenlex pinned this issue Mar 10, 2024
@zenlex
Copy link
Contributor Author

zenlex commented Apr 2, 2024

I added a services section. To make this easier for multiple hands to work on I propose we abstract the database ops to a service layer so the routes can get built calling the service API without worrying about the underlying DB queries and the services can just be responsible for the queries.

@zenlex
Copy link
Contributor Author

zenlex commented Apr 9, 2024

I'm fine with sql.unsafe`` queries as desired for now. If anyone wants to add query validation, check the slonik docs, but the basics are:

  • add zod object for the database type (TypeScript can infer the type from this, so don't make a separate TS type)
  • add runtime interceptor (default implementation from slonik docs should be fine) which will automatically validate query results with sql.type([zod type])...

@zenlex
Copy link
Contributor Author

zenlex commented May 14, 2024

Proposals needs a tiny bit of updating and then it's ready for QA

  • refactor update to use zod partial
  • match validators to updated api schema

@zenlex
Copy link
Contributor Author

zenlex commented Jun 8, 2024

just need to wrap up #50 added to the voting service/router and then finish testing/debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant