Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can we have the result of online_photometric_calibration, like manual photometric calibration to get calibrate response result pcalib.txt and calibrated vignette result vignette.png ? #4

Open
zhang412yi opened this issue Jun 15, 2018 · 3 comments

Comments

@zhang412yi
Copy link

No description provided.

@NikolausDemmel
Copy link
Contributor

At the moment this is not implemented unfortunately, but a PR would be welcome!

@wyang22
Copy link

wyang22 commented Jun 27, 2018

What does the PR mean here? Can you help to evalute the efforts if we want to use this online calibration code to generate the pcalib.txt and vignette.png? Thanks

@NikolausDemmel
Copy link
Contributor

PR means pull request. I.e. we would welcome contributions of others that would add such functionality.

I'm not sure about the effort. I have to admit that I am not familiar with the code base in detail (@PaulBergmann knows more), but you would have to check the code to see how the response function and vignette models are stored. You can also check https://github.com/tum-vision/mono_dataset_code to see how the files are stored and loaded there. This the online-calibration code uses parameteric models, you will have to discretise/sample them accordingly to the mono-dataset-code format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants