Switch testing to Fastlane + add SwiftLint #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moves Build and Test step to Fastlane script (the results are a bit better with CircleCI) - Removes the Pods from KanvasCameraExample - Switches to the Cocoapods CDN source for faster builds - Removes the process.yml which is not needed
jschementi
suggested changes
Nov 19, 2020
| name: Linting | ||
| command: bundle install; bundle exec fastlane lint | ||
| - run: | ||
| name: Build for Testing |
There was a problem hiding this comment.
Let' call this "Build and Test"
Comment on lines
+45
to
52
| - store_test_results: | ||
| path: ./KanvasCameraExample/output/scan | ||
| - store_artifacts: | ||
| path: output | ||
| - store_test_results: | ||
| path: output/scan | ||
| - ios/save-xcodebuild-artifacts | ||
| - ios/save-xcodebuild-artifacts: |
There was a problem hiding this comment.
This is duplicating steps in Ci, and the duplicates seem to be silently failing:
| fastlane/Preview.html | ||
| fastlane/report.xml | ||
| fastlane/README.md | ||
|
|
||
| KanvasCameraExample/Pods/* | ||
| !KanvasCameraExample/Pods/Target\ Support\ Files/ |
There was a problem hiding this comment.
I think we can remove this line, since you're deleting those files too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two primary things:
More specifically:
.swiftlint.ymlfor local and CI lintingswiflint(this is the same code WordPress-iOS uses but put into a Fastlane action)lintfastlane lane to run linting