From 38dd2c3bf26cb1a04704f2fae2407fd1e9134827 Mon Sep 17 00:00:00 2001 From: puxiao Date: Wed, 27 Nov 2024 16:19:57 +0800 Subject: [PATCH 1/3] fix: Modal warning issue --- src/modal/src/Modal.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/src/modal/src/Modal.tsx b/src/modal/src/Modal.tsx index ed286d0b8ed..d1453265a05 100644 --- a/src/modal/src/Modal.tsx +++ b/src/modal/src/Modal.tsx @@ -347,7 +347,6 @@ export default defineComponent({ default: () => { return this.show ? (
Date: Wed, 27 Nov 2024 16:26:31 +0800 Subject: [PATCH 2/3] update CHANGELOG --- CHANGELOG.en-US.md | 1 + CHANGELOG.zh-CN.md | 1 + 2 files changed, 2 insertions(+) diff --git a/CHANGELOG.en-US.md b/CHANGELOG.en-US.md index 74daffee2d1..c8f4c99d5ea 100644 --- a/CHANGELOG.en-US.md +++ b/CHANGELOG.en-US.md @@ -9,6 +9,7 @@ - Fix `n-time-picker`'s `use-12-hours` type error warning, closes [#4308](https://github.com/tusen-ai/naive-ui/issues/4308) - Fix `input-number` the problem that the negative sign is replaced when the negative sign is entered. - Fix `n-data-table`'s header will show scrollbar in some old browsers, closes [#6557](https://github.com/tusen-ai/naive-ui/issues/6557). +- Fix browser warnings caused by `aria-hidden` attribute in `Modal`, closes [#6436](https://github.com/tusen-ai/naive-ui/issues/6436) ### Features diff --git a/CHANGELOG.zh-CN.md b/CHANGELOG.zh-CN.md index 6cf9772ae01..1d2640f2e3b 100644 --- a/CHANGELOG.zh-CN.md +++ b/CHANGELOG.zh-CN.md @@ -9,6 +9,7 @@ - `n-time-picker` 的 `use-12-hours` 类型错误警告,关闭 [#4308](https://github.com/tusen-ai/naive-ui/issues/4308) - 修复 `input-number` 存在负号时被替换的问题 - 修复 `n-data-table` 的 header 在部分浏览器中会出现滚动条,关闭 [#6557](https://github.com/tusen-ai/naive-ui/issues/6557) +- 修复 `Modal` 中 `aria-hidden` 属性引发的浏览器警告,关闭 [#6436](https://github.com/tusen-ai/naive-ui/issues/6436) ### Features From 07d83f40b90e1dc1459f7a8f134c17249ea74150 Mon Sep 17 00:00:00 2001 From: puxiao Date: Wed, 27 Nov 2024 16:39:32 +0800 Subject: [PATCH 3/3] update CHANGELOG --- CHANGELOG.en-US.md | 2 +- CHANGELOG.zh-CN.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.en-US.md b/CHANGELOG.en-US.md index c8f4c99d5ea..2ebc37ca063 100644 --- a/CHANGELOG.en-US.md +++ b/CHANGELOG.en-US.md @@ -9,7 +9,7 @@ - Fix `n-time-picker`'s `use-12-hours` type error warning, closes [#4308](https://github.com/tusen-ai/naive-ui/issues/4308) - Fix `input-number` the problem that the negative sign is replaced when the negative sign is entered. - Fix `n-data-table`'s header will show scrollbar in some old browsers, closes [#6557](https://github.com/tusen-ai/naive-ui/issues/6557). -- Fix browser warnings caused by `aria-hidden` attribute in `Modal`, closes [#6436](https://github.com/tusen-ai/naive-ui/issues/6436) +- Fix `n-modal` has log warnings of console when use `aria-hidden` attribute, closes [#6436](https://github.com/tusen-ai/naive-ui/issues/6436) ### Features diff --git a/CHANGELOG.zh-CN.md b/CHANGELOG.zh-CN.md index 1d2640f2e3b..783f1f03e8a 100644 --- a/CHANGELOG.zh-CN.md +++ b/CHANGELOG.zh-CN.md @@ -9,7 +9,7 @@ - `n-time-picker` 的 `use-12-hours` 类型错误警告,关闭 [#4308](https://github.com/tusen-ai/naive-ui/issues/4308) - 修复 `input-number` 存在负号时被替换的问题 - 修复 `n-data-table` 的 header 在部分浏览器中会出现滚动条,关闭 [#6557](https://github.com/tusen-ai/naive-ui/issues/6557) -- 修复 `Modal` 中 `aria-hidden` 属性引发的浏览器警告,关闭 [#6436](https://github.com/tusen-ai/naive-ui/issues/6436) +- 修复 `n-modal` 中 `aria-hidden` 属性引发的控制台报警告,关闭 [#6436](https://github.com/tusen-ai/naive-ui/issues/6436) ### Features