pass import path instead of callable in 'screenshot_apps' #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azmeuk
force-pushed
the
29-wsgi-apps-fix
branch
2 times, most recently
from
eac5926 to
c44b34f
Compare
|
I am not sure why the CI fails, since it succeeds locally 🤔 |
tushuhei
requested changes
Dec 24, 2024
tushuhei
reviewed
Dec 24, 2024
azmeuk
force-pushed
the
29-wsgi-apps-fix
branch
5 times, most recently
from
722ff90 to
a0d8c5e
Compare
azmeuk
force-pushed
the
29-wsgi-apps-fix
branch
from
a0d8c5e to
db07c66
Compare
|
This is all green now. I had to force a minimum HTML style and fix the content-type. |
tushuhei
approved these changes
Dec 25, 2024
|
This is awesome! Thank you for the completion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #29