Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TWAIN.cs Incorrectly Logs REGISTER_CALLBACK #33

Open
mattzirkle opened this issue May 26, 2019 · 1 comment
Open

TWAIN.cs Incorrectly Logs REGISTER_CALLBACK #33

mattzirkle opened this issue May 26, 2019 · 1 comment

Comments

@mattzirkle
Copy link

If you look in the method TWAIN::DatIdentity, you will find that if you are using callbacks that the logging uses the same message passed in instead of using MSG.REGISTER_CALLBACK. Here is the offending line of code:
Log.LogSendBefore(a_dg.ToString(), DAT.CALLBACK.ToString(), a_msg.ToString(), CallbackToCsv(twcallback));

Just need to replace a_msg.ToString() with MSG.REGISTER_CALLBACK.ToString(). Pretty trivial, but it makes me look twice when looking at the log file.

@mattzirkle
Copy link
Author

Also just noticed that the logging of the response doesn't use AutoDatStatus, meaning in the case of a failure that you can't get to the TWCC value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant