Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version number outdated? #768

Closed
BT643 opened this issue Jan 5, 2021 · 2 comments
Closed

Version number outdated? #768

BT643 opened this issue Jan 5, 2021 · 2 comments

Comments

@BT643
Copy link

BT643 commented Jan 5, 2021

I downloaded the v1.15.3 release and did:

npm install
npm run build

Then included the twig.js file in a website to be used in the browser. When I do alert(Twig.VERSION); I get 1.14.0 alerted out.

Am I misunderstanding what this version is, or does it need updating somewhere?

The following code is in twig.js around line 460 so I guess it needs updating there?

// ## twig.factory.js
//
// This file handles creating the Twig library
module.exports = function factory() {
  var Twig = {
    VERSION: '1.14.0'
  };

Apologies if I'm misunderstanding! Thanks.

@RobLoach
Copy link
Collaborator

RobLoach commented Jan 5, 2021

Whoops! Good catch!

@willrowe
Copy link
Collaborator

@BT643 keeping the internal Twig.VERSION in sync with the npm releases is a known issue. Efforts to automate the process can be tracked on #569.

@willrowe willrowe closed this as not planned Won't fix, can't repro, duplicate, stale Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants