Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unnecessary API calls #2

Open
samuelmeuli opened this issue Apr 13, 2020 · 0 comments
Open

Avoid unnecessary API calls #2

samuelmeuli opened this issue Apr 13, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@samuelmeuli
Copy link
Collaborator

For simplicity, the current implementation calls the refreshBookmarks function to update the UI after every modification to the bookmark tree. This obviously isn't very efficient. Instead of calling this function, the flattened bookmark tree (in the Redux store) could be modified directly.

Example:

https://github.com/samuelmeuli/quick-start/blob/4daf1c457e67b9ee68d1ccd965c641e600ea5bba/src/content/store/thunks.ts#L24-L31
@samuelmeuli samuelmeuli added the enhancement New feature or request label Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samuelmeuli