Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are unnecessary "White()" tokens in the pyparsing expressions for actions #118

Open
exarkun opened this issue Nov 29, 2020 · 0 comments · May be fixed by #119
Open

There are unnecessary "White()" tokens in the pyparsing expressions for actions #118

exarkun opened this issue Nov 29, 2020 · 0 comments · May be fixed by #119

Comments

@exarkun
Copy link
Member

exarkun commented Nov 29, 2020

By default pyparsing skips over all leading whitespace before attempting to match the next element in an expression. Thus, all of the explicit White() terms in our action definitions are redundant. We can just delete them.

Naively doing so does introduce an ambiguity between Take and TakeFrom but these should be one action anyway so I'm also going to take the excuse to merge them. This shortens the implementation and fixes some divergences between the two in some exception handling behavior.

@exarkun exarkun linked a pull request Nov 29, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant