Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edge case regex pattern colorization #668

Open
tristanlatr opened this issue Nov 29, 2022 · 1 comment · May be fixed by #678
Open

Edge case regex pattern colorization #668

tristanlatr opened this issue Nov 29, 2022 · 1 comment · May be fixed by #678
Labels
bug

Comments

@tristanlatr
Copy link
Contributor

Some regex patterns are not colorized correctly. We could add a check to ensure that the colorized pattern round trips, and if it doesn’t then we fallback to the generic string colorization.

#667 (comment)

Since we know our regex colorizer is not perfect, we shouldn’t emit warnings about failures in the regex colorizing.
tristanlatr added a commit that referenced this issue Jan 23, 2023
@tristanlatr
Trying to fix #668
2d33e16
@tristanlatr tristanlatr linked a pull request Jan 23, 2023 that will close this issue
Open
@tristanlatr
Copy link
Contributor Author

In terms of alternatives I found the following:

It might be less work to properly adjust sre_parse36.py to only to the roundtripable parsing job without any optimizations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix corner case regex colorization twisted/pydoctor
1 participant
@tristanlatr