Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A variable under a conditional statement marked as Final should be handled like a constant #818

Open
tristanlatr opened this issue Sep 25, 2024 · 0 comments

Comments

@tristanlatr
Copy link
Contributor

This piece of code does is accepted by mypy, so the astbuilder.is_constant() function should be adjusted.

if sys.version_info > (3,10):
    v:Final = 1
else:
    v:Final = 2

Let's note that mypy complains for the following code, but pydoctor should not make this extra step and still mark it as constant imo.

if random.choice([True, False]):
    v:Final = 1
else:
    v:Final = 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant