Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VNC window should scale down when exceeding max dimensions #6

Open
jhass opened this issue Nov 5, 2015 · 2 comments · May be fixed by #9
Open

VNC window should scale down when exceeding max dimensions #6

jhass opened this issue Nov 5, 2015 · 2 comments · May be fixed by #9

Comments

@jhass
Copy link

jhass commented Nov 5, 2015

Right now it runs out on the bottom when inside the arch iso for example.

@yamamushi
Copy link

👍

TheTechmage added a commit to TheTechmage/twitch-viewer that referenced this issue Nov 6, 2015
This change should allow the VNC window to resize to the size of it's
parent div when ever the window is resized, or when the vnc window
itself is resized. Therefore, this fixes twitchintheshell#6.

Based off of
https://github.com/jakozaur/noVNC/blob/master/meteor/novnc.js#L56 since
it was the original code that resized the window (and I don't know
meteor or noVnc really well).

Signed-off-by: Colton Wolkins (Ogre) <[email protected]>
@TheTechmage TheTechmage linked a pull request Nov 6, 2015 that will close this issue
@TheTechmage
Copy link

Thanks to yamamushi for pointing out this ticket to me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants