twitter-mysql-ca173b6 was failed to make with the newest google-breakpad #2
Comments
liangg
pushed a commit
that referenced
this issue
Jun 11, 2013
Twitter DBA audit logging writes activities by concerned users to error log. By default, all users are logged, except users with a new IGNORE LOGGING privilege. That is, users can be dynamically registered for audit logging with IGNORE LOGGING privilege grant. Remove --general_log_super_only general log superuser filtering, and --general_log_query_error that was added for MYSQL-146. Remove log_super_only test and sys_vars baisc tests. Requirement #1: A new global system variable --twitter_audit_logging is used to set audit log level with valid range [0,2]. Requirement #2: A new privilege IGNORE LOGGING is added to dynamically enable user for audit logging. Root users with all privileges are always logged. For example, grant IGNORE LOGGING on *.* to user_no_log; Requirement #3: Eligible activities are logged to error log file with a new twitter_log_write() function. Enable and disable of twitter audit logging are logged. Requirement #4: Log line format is as follows, where timestamp format is YYYY-MM-DD HH:MM:SS. local_timestamp<tab>user@host_or_ip<tab>result<tab>query_string Requirement #5: SELECT and SHOW query commands are not logged, unless option --twitter_audit_logging = 2. Requirement #6: Query result is logged in the log line in form of error code, code 0 for success and error code for failure. Requirement #7: User logins incl. failures are logged for users without the IGNORE LOGGING privilege.
kevincrane
pushed a commit
that referenced
this issue
Aug 21, 2014
The test case makes use of the fine DEBUG_SYNC facility. Furthermore, since it needs synchronization on internal threads (dump and SQL threads) the server code has DEBUG_SYNC commands internally deployed and activated through the DBUG_EXECUTE_IF macro. The internal DBUG_SYNC commands are then controlled from the test case through the DEBUG variable. There were three problems around the DEBUG + DEBUG_SYNC facility usage: 1. When signaling the SQL thread to continue, the test would reset immediately the DEBUG_SYNC variable. This could mean that the SQL thread might loose the signal and continue to wait forever; 2. A similar scenario was happening with the dump thread on the master. This thread was instructed to wait, and later it would be signaled to continue, but immediately after the DEBUG_SYNC would be reset. This could lead to the dump thread missing the signal and wait forever; 3. The test was not cleaning itself up with respect to the instrumentation of the dump thread. This would leave the conditional execution of an internal DEBUG_SYNC command active (through the usage of DBUG_EXECUTE_IF). We fix #1 and #2 by waiting for the threads to receive the signal and only then issue the reset. We fix #3 by reseting the DEBUG variable, thus deactivating the dump thread internal DEBUG_SYNC command. --BZR-- revision-id: [email protected] property-audit-revid: [email protected] property-branch-nick: mysql-5.5 testament3-sha1: 5f8bb46be17109262dbc24ebeadb1d51f26cbae8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
twitter-mysql-ca173b6 was failed to make with the newest google-breakpad
caused by two change:
in sql/minidump.cc:
dump_callback(const char *dump_path,
const char *minidump_id,
void *,
bool succeeded)
in client/linux/handler/exception_handler.h
typedef bool (MinidumpCallback)(const MinidumpDescriptor& descriptor,
void context,
bool succeeded);
The text was updated successfully, but these errors were encountered: