You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 13, 2021. It is now read-only.
Line 65 of this file edmTail.cpp contains the following line return lWeight*(quant*(lu-l)+l) + rWeight*(quant*(u-rl)+rl);
where
lu = (u+l)/2;
rl = (u+lu)/2;
This seems wrong. Shouldn't this be: return lWeight*(quant*(lu-l)+l) + rWeight * (quant*(u-lu)+lu);
Simple visulization of the problem:
say we have the line return lWeight * ML + rWeight * MR;
The current implementation is returning the first case while it should be the second case.
l.....................ML..................... lu ......................rl.............MR.............u
l.....................ML.................... lu ......................MR..........................u
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Line 65 of this file edmTail.cpp contains the following line
return lWeight*(quant*(lu-l)+l) + rWeight*(quant*(u-rl)+rl);
where
This seems wrong. Shouldn't this be:
return lWeight*(quant*(lu-l)+l) + rWeight * (quant*(u-lu)+lu);
Simple visulization of the problem:
say we have the line
return lWeight * ML + rWeight * MR;
The current implementation is returning the first case while it should be the second case.
l.....................ML..................... lu ......................rl.............MR.............u
l.....................ML.................... lu ......................MR..........................u
The text was updated successfully, but these errors were encountered: