Skip to content
This repository has been archived by the owner on Nov 13, 2021. It is now read-only.

Potentail bug while calculating approxmiate median #23

Open
utkrist opened this issue Jul 10, 2016 · 0 comments
Open

Potentail bug while calculating approxmiate median #23

utkrist opened this issue Jul 10, 2016 · 0 comments

Comments

@utkrist
Copy link

utkrist commented Jul 10, 2016

Line 65 of this file edmTail.cpp contains the following line
return lWeight*(quant*(lu-l)+l) + rWeight*(quant*(u-rl)+rl);
where

lu = (u+l)/2;
rl = (u+lu)/2;

This seems wrong. Shouldn't this be:
return lWeight*(quant*(lu-l)+l) + rWeight * (quant*(u-lu)+lu);

Simple visulization of the problem:
say we have the line return lWeight * ML + rWeight * MR;
The current implementation is returning the first case while it should be the second case.

l.....................ML..................... lu ......................rl.............MR.............u

l.....................ML.................... lu ......................MR..........................u

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant