Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve session handling #6

Closed
ty-a opened this issue Nov 25, 2018 · 1 comment
Closed

Improve session handling #6

ty-a opened this issue Nov 25, 2018 · 1 comment
Labels
invalid This doesn't seem right

Comments

@ty-a
Copy link
Owner

ty-a commented Nov 25, 2018

We currently seem to be running into race conditions with sessions being saved and being redirected to the next page on the production site.

Either investigate using different session handling middleware, or call the req.session.save() ourselves and have all redirecting code be in the callback.
@ty-a ty-a added the bug Something isn't working label Nov 25, 2018
@ty-a
Copy link
Owner Author

ty-a commented Nov 28, 2018

Or, it was something even easier to fix because of our reverse proxy making our secure cookies fail.

@ty-a ty-a closed this as completed Nov 28, 2018
@ty-a ty-a added invalid This doesn't seem right and removed bug Something isn't working labels Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ty-a