Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling #9

Open
tychedelia opened this issue Nov 26, 2022 · 2 comments
Open

Error handling #9

tychedelia opened this issue Nov 26, 2022 · 2 comments

Comments

@tychedelia
Copy link
Owner

Error handling is a bit of a mess right now. We emit two different serde errors with very little context, that also don't impl std::error::Error which makes them hard to interact with.
tychedelia pushed a commit that referenced this issue Nov 26, 2022
Temp fix for #9, will need longer term fix.
c18de1b
@michaelbeaumont
Copy link

is there a chance we could switch to thiserror with structured errors?

@rukai
Copy link
Collaborator

rukai commented Feb 28, 2025

It was a while ago but when investigating how to do errors for this library I came to the conclusion that there was no value in using structured errors because all errors will be handled in the same way anyway. Are there any examples you have of error cases that require different handling?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@michaelbeaumont @rukai @tychedelia