Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support scalatest mixins #27

Open
Daenyth opened this issue Sep 30, 2020 · 4 comments
Open

Support scalatest mixins #27

Daenyth opened this issue Sep 30, 2020 · 4 comments

Comments

@Daenyth
Copy link
Contributor

Daenyth commented Sep 30, 2020

To help this be a better drop-in upgrade from scalatest-scalacheck, it would help to have mixins that provide forAll helpers in the style of ScalaCheckPropertyChecks

@mpilquist
Copy link
Member

I personally prefer the mixin style but didn't want scalacheck-effect to diverge from the syntax used by munit-scalacheck. If there was a mixin trait in munit-scalacheck that provided the various forAll definitions, I'd have no problem adding a similar forAllF mixin to this project.

@Daenyth
Copy link
Contributor Author

Daenyth commented Nov 17, 2020

If it was restricted to a scalacheck-effect-scalatest package, would that help?

@mpilquist
Copy link
Member

I don't think so, as we'd still have the same disparity between forAll and forAllF. Given that ScalaTest doesn't support forAllF at all, I think what you're really after is a forAll mixin for vanilla Prop values.

Note source compatibility is generally just an import away -- import org.scalacheck.Prop.forAll

@lacarvalho91
Copy link

i've been looking into how to use scalacheck in scalatest for properties that return an effect, i came across https://gist.github.com/mpilquist/7dd30a44ca2a7fe0cd494d9b04e4f661#file-eff-scala from yourself @mpilquist

is that not what we're after in this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants