-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove UserAgentParser.parse #14
Comments
@toolmantim Is this still relevant? |
@wallin This is still relevant. We hit this footgun using the class method in a rails request - loading the yaml and compiling the regexes on every request. This added about 40-50ms per-request, which is quite unexpected and one of those things that's really easy to miss when you first introduce using this gem - though I appreciate the readme does attempt to address it. If the docs clearly stated "Expect this method to take 50ms" I suspect nobody would use it. I support this issue. |
First step could be to add a deprecation warning maybe? That could already educate and also help transition. |
It causes unexpected performance problems (#4 #5 #13). The simpler
UserAgentParser.new.parse
should be less confusing.A backwards incompatible change for v3.
The text was updated successfully, but these errors were encountered: