-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor code in ActsAsRDFable #17
Comments
Is this where the serialization code is used? https://github.com/ualbertalib/oaisys/blob/4d0f657480658343ba01cfe39f71ef0060ccdcab/app/views/oaisys/pmh/list_records.xml.builder#L33 |
Looks like your right! Will remove that bullet 👍 |
|
Yeah, it's being used in a few places, but I'm not sure why? E.g ActiveStorage::Blob inherits from ActiveRecord::Base, therefore it would get Basically, we got two different ways to include this gem, which seems odd. Unless this gem is being used with a "non-active record" class 🤔 |
It appears there may be some low-hanging fruit for quick refactors and improvements to this gem.
I see a few improvements:
ActsAsRdfableCore
?add_annotation_bindings!
when all models currently include this gem? Is it a good idea to make all models include this gem?ActiveSupport::Configurable
instead of our own code insideconfig.rb
The text was updated successfully, but these errors were encountered: