Skip to content
This repository has been archived by the owner on Dec 22, 2022. It is now read-only.

[Discovery]Update database config to depend on DATABASE_URL #1618

Open
pgwillia opened this issue Apr 25, 2019 · 0 comments
Open

[Discovery]Update database config to depend on DATABASE_URL #1618

pgwillia opened this issue Apr 25, 2019 · 0 comments
Labels
current phase issues identified as need to be fixed in current phase technical-debt

Comments

@pgwillia
Copy link
Member

pgwillia commented Apr 25, 2019

We've introduced password environment variables in three places config/database.yml and docker-compose.lightweight.yml/docker-compose.yml and .env_deployment_sample. We should simplify this scheme to use DATABASE_URL/DISCOVERY_DATABASE_URL instead which will allow more flexibility for how the database is setup. See https://github.com/ualbertalib/jupiter/blob/add9c58c6b8c9642931a2e58e296c8ce3bd923c6/docker-compose.yml#L61 and

default: &default
adapter: mysql2
encoding: utf8
pool: <%= ENV.fetch("RAILS_MAX_THREADS") { 5 } %>
username: root
password: <%= ENV['DISCOVERY_DATABASE_PASSWORD'] || 'mysecretpassword' %>
host: 127.0.0.1

Originally posted by @pgwillia in #1591

@weiweishi weiweishi added the current phase issues identified as need to be fixed in current phase label Apr 30, 2019
@weiweishi weiweishi changed the title Update database config to depend on DATABASE_URL [Discovery]Update database config to depend on DATABASE_URL Jun 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current phase issues identified as need to be fixed in current phase technical-debt
Projects
None yet
Development

No branches or pull requests

2 participants