Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform in the base indexer file choosing logic. #52

Open
fsgeek opened this issue May 27, 2024 · 1 comment
Open

Add platform in the base indexer file choosing logic. #52

fsgeek opened this issue May 27, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fsgeek
Copy link
Contributor

fsgeek commented May 27, 2024

In building the Dropbox ingester, I found that the base package is returning a file that wasn't specific to Dropbox. I think the right long-term solution is to allow specializing this interface to only return entries for a specific platform.

This is a work item to track doing this - it's not high priority, but I don't want to forget it either.

@fsgeek fsgeek added enhancement New feature or request good first issue Good for newcomers labels May 27, 2024
@fsgeek fsgeek self-assigned this May 27, 2024
@fsgeek
Copy link
Contributor Author

fsgeek commented May 27, 2024

See commit a4e0cd2 for the change I made to achieve this just for Dropbox. It may justify more generality. Changing this will impact any other component using the base implementation in the IndalkeoIndexer.py file.

fsgeek pushed a commit that referenced this issue May 27, 2024
…ack generalizing and moving this logic into the base class, in which case the ingester specific implementation could be removed.
hadisinaee added a commit that referenced this issue May 28, 2024
The current version of getting the exec path of the given pid is buggy
and I couldn't fix it. see #52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant