From bc9fb4d1467ac5d88a5c2438530b05b07ef9da1f Mon Sep 17 00:00:00 2001 From: r-hang Date: Tue, 14 May 2024 15:42:14 -0600 Subject: [PATCH] golangci: Run install step with --help (#97) PR builds have been failing with an unknown flag error ``` run golangci-lint Running [/home/runner/golangci-lint-1.58.1-linux-amd64/golangci-lint run --version] in [/home/runner/work/cff/cff] ... Error: unknown flag: --version Failed executing command with error: unknown flag: --version ``` ref: https://github.com/uber-go/cff/actions/runs/9061971983/job/24894837626?pr=96 --version is a valid flag for golangci-lint but not golangci-lint run. For golangci-lint run, the closest no-op action is --help. Fix golangci-lint runs by using the --help flag instead of the version flag. --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 908c9c4..2d64d72 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -25,7 +25,7 @@ jobs: name: Install golangci-lint with: version: latest - args: --version # make lint will run the linter + args: --help # make lint will run the linter - run: make lint name: Lint