Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/tests: Fix double generate #7

Open
abhinav opened this issue Oct 19, 2022 · 0 comments
Open

internal/tests: Fix double generate #7

abhinav opened this issue Oct 19, 2022 · 0 comments
Labels
housekeeping Chores and cleanup tasks.

Comments

@abhinav
Copy link
Collaborator

abhinav commented Oct 19, 2022

The tests in internal/tests currently have a hacky "invoke cff twice" setup:

  • once to generate the code for the test that needs --auto-instrument
  • once to generate everything else

The test that relies on auto instrument is tagged with autoinstrument,
but we generate everything with auto-instrument,
and then replace it in the second call.

This is inefficient and we should fix it.
@abhinav abhinav added the housekeeping Chores and cleanup tasks. label Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
housekeeping Chores and cleanup tasks.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abhinav