Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aquaregia_test: Better error message matching #9

Open
abhinav opened this issue Oct 19, 2022 · 0 comments
Open

aquaregia_test: Better error message matching #9

abhinav opened this issue Oct 19, 2022 · 0 comments

Comments

@abhinav
Copy link
Collaborator

abhinav commented Oct 19, 2022

A major piece of debt in aquaregia_test (which verifies error messages for failing test cases)
is that it just searches for N instance of error X in the output.
We can do better: we should assert error messages at specific positions.

One way we could do this is how analysistest expects error messages: with // want comments next to where the errors are expected.

We should also move all the test cases to a testdata/ folder so we don't have to tag them with the failing constraint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant