This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

code structure improvements #29

Open

jozef-slezak opened this issue May 6, 2018 · 1 comment

jozef-slezak commented May 6, 2018

Hello, I would like to ask you if you would accept following code structure improvements (if so, I could help with a pull request):

use logger interface (instead of *zap.Logger) - we could inject different logger implementations in different projects
renaming package util to set (util packages - golang antipattern)
*_test package (see https://medium.com/@povilasve/go-advanced-tips-tricks-a872503ac859)

Thank you

Collaborator

zhixinwen commented May 12, 2018

For test packages, looks like it would be used for testing API only, but we would still want to test private methods.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.