Fix backwards-incompatible calls to ASTHelpers.hasDirectAnnotationWithSimpleName #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msridhar
commented
Jan 13, 2024
| @@ -21,7 +21,8 @@ plugins { | |||
| } | |||
|
|
|||
| configurations { | |||
| nullawayJar | |||
There was a problem hiding this comment.
removed this configuration as it is no longer used
|
@yuxincs this fixes the issue that caused release 0.10.20 to be unusable on older Error Prone versions |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #894 +/- ##
=========================================
Coverage 86.94% 86.95%
- Complexity 1952 1953 +1
=========================================
Files 77 77
Lines 6314 6315 +1
Branches 1222 1222
=========================================
+ Hits 5490 5491 +1
Misses 420 420
Partials 404 404 ☔ View full report in Codecov by Sentry. |
yuxincs
approved these changes
Jan 14, 2024
Comment on lines
+115
to
+117
| // A bit of a hack: we add the dependencies of the oldest supported Error Prone version to the _beginning_ of the | ||
| // classpath, so that they are used instead of the latest version. This exercises the scenario of building | ||
| // NullAway against the latest supported Error Prone version but then running on the oldest supported version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error Prone 2.24.0 introduces new overloads of
ASTHelpers.hasDirectionAnnotationWithSimpleName; see google/error-prone@aa6e3e7. This causes backward compatibility issues when compiling against EP 2.24.0+ and then running on an older version of Error Prone. We introduce a wrapper method to avoid this issue. We also modify ourtestJdk8tasks to properly test the scenario of compiling against the newest supported Error Prone version and then running on the oldest supported version, which would have caught this issue.Ideally we would have our own EP check preventing direct calls to
ASTHelpers.hasDirectionAnnotationWithSimpleName, but that can be done in a follow-up.