Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

h3ToComponents rename to cellToComponents #730

Open
mrdvt92 opened this issue Nov 14, 2022 · 2 comments
Open

h3ToComponents rename to cellToComponents #730

mrdvt92 opened this issue Nov 14, 2022 · 2 comments

Comments

@mrdvt92
Copy link

mrdvt92 commented Nov 14, 2022

In keeping with the 4.0.1 functional renames, should h3ToComponents be renamed to cellToComponents?

[build]$ ls -l bin/h3*
-rwxrwxr-x. 1 user group 23520 Nov 14 15:24 bin/h3
-rwxrwxr-x. 1 user group 23600 Nov 14 15:24 bin/h3ToComponents
-rwxrwxr-x. 1 user group 23432 Nov 14 15:25 bin/h3ToHier
$ ./bin/h3ToComponents --help
./bin/h3ToComponents: Converts H3 indexes to component parts
H3 4.0.1
        -h, --help      Show this help message.
        -v, --verbose   Verbose output mode.
        -i, --index <index>     Index, or not specified to read indexes from standard input.
@nrabinowitz
Copy link
Collaborator

👍 Yes, we should rename

@isaacbrodsky
Copy link
Collaborator

isaacbrodsky commented Mar 10, 2023

I think this was left this way because it should be able to accept any H3Index, such as an edge or vertex. If it works on any index, we might want to rename it to indexToComponents or toComponents in the h3 CLI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants