Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Rx from Needle examples #251

Open
ebgraham opened this issue Feb 14, 2019 · 2 comments
Open

Remove Rx from Needle examples #251

ebgraham opened this issue Feb 14, 2019 · 2 comments
Labels
Help wanted Extra attention is needed

Comments

@ebgraham
Copy link

The Needle sample projects are overly complicated and have no particular need for a dependency on Rx and Carthage. Examples should ideally have no dependencies outside of vanilla iOS and Needle, and allow the developer to focus use of the framework. Rx makes following the project calls complicated and raises the bar for learning from the examples.

@neakor
Copy link
Contributor

neakor commented Feb 15, 2019

This is a great point! The current sample is simply a port of Uber's internal training material. Internally we use Rx heavily, hence why that got ported over as well. We should definitely update this. Do you think you can help with this @ebgraham ?

@neakor neakor added the Help wanted Extra attention is needed label Feb 15, 2019
@monishsyed
Copy link

Hey @neakor @ebgraham, Hope you all are doing well. I took a stab adding a non-rx sample to the repo :) Would be great to have your eyes on it. Looking forward to the feedback. Thank you :)

#356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants