Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

(v1.x) 2x listen possible with undefined behavior, trivially avoided #1224

Open
benfleis opened this issue Aug 26, 2015 · 0 comments
Open

(v1.x) 2x listen possible with undefined behavior, trivially avoided #1224

benfleis opened this issue Aug 26, 2015 · 0 comments
Labels

Comments

@benfleis
Copy link
Contributor

In v1.x code, .listen() can be called twice in a destructive way. I don't completely understand the path, but the evidence was clear. When using nodejs/cluster, 2 calls to .listen() can occur, and can create 2 different sockets, both listening on the same port. (Observed via lsof.)

This is avoided in v2 by asserting that .listen isn't already called, and I would propose adding a similar trivial patch to the v1.x branch.

@benfleis benfleis added the bug label Aug 26, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant